Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add section on manual style to Writing Guidelines #10169

Merged
merged 1 commit into from
Nov 17, 2024

Conversation

tetrapod00
Copy link
Contributor

@tetrapod00 tetrapod00 commented Oct 30, 2024

Resolves #5932.

Adds several guidelines on formatting and style for the manual specifically. I documented existing usage as best I could, plus a few opinionated changes that are not yet widespread across the manual, such as linking to project settings.

@tetrapod00 tetrapod00 marked this pull request as draft October 30, 2024 04:41
@Calinou Calinou added enhancement area:contributing Issues and PRs related to the Contributing/Development section of the documentation cherrypick:4.3 labels Nov 5, 2024
@tetrapod00

This comment was marked as resolved.

Specifies when to link to the class reference.
Specifies how to style various kinds of text.
@tetrapod00 tetrapod00 marked this pull request as ready for review November 5, 2024 09:29
Comment on lines +662 to +669
.. tip:: In most text editors, you can add a vertical guide or "ruler" at 80
characters. For example, in Visual Studio Code, you can add the following to
your ``settings.json`` to add rulers at 80 and 100 characters:

.. code:: json

"editor.rulers": [80,100],

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about this. We can't list how to do it in all editors. Is VS Code common enough to show favoritism here?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I'd say VS Code is pretty much the "default" text editor for most people at this point (especially when no IDE fits the bill).

@tetrapod00 tetrapod00 changed the title [Draft] Add section on manual style to Writing Guidelines Add section on manual style to Writing Guidelines Nov 5, 2024
@tetrapod00
Copy link
Contributor Author

I have noticed that with these additions, the Writing Guidelines page is getting a little long and disorganized, and the Writing documentation section in general also perhaps needs reorganization. This new section could arguably be a new page under Writing the manual rather than a section on this page.

I'd like to continue adding style and content guidelines for a little while (I have a couple more PRs in mind after this one), then address the potential reorganization of these pages. Since these are contributing pages that not much depends on, there should be little harm caused by shuffling content around after it's added, if necessary.

@mhilbrunner mhilbrunner merged commit dfb8a18 into godotengine:master Nov 17, 2024
1 check passed
@mhilbrunner
Copy link
Member

Thanks! Merged. Not cherry-picking this one, as we pretty much expect people to use master/latest for all rules and guidelines unless they have very good reasons not to. Long term, we really need to make sure we host these pages only on latest/move contributor docs elsewhere (as discussed in that RC thread).

@tetrapod00 tetrapod00 deleted the manual-style-guide branch November 17, 2024 18:02
@tetrapod00 tetrapod00 mentioned this pull request Dec 3, 2024
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:contributing Issues and PRs related to the Contributing/Development section of the documentation enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Define standard referencing/formatting behavior for class and property names in classref and manual pages
3 participants